This is a static archive of the previous Open Grid Forum GridForge content management system saved from host forge.ogf.org file /sf/discussion/do/listPosts/projects.ggf-editor/discussion.rec_saga_spec.topc3998 at Thu, 03 Nov 2022 23:19:24 GMT SourceForge : Post

Project Home

Tracker

Documents

Tasks

Source Code

Discussions

File Releases

Wiki

Project Admin
Project: Editor     Discussion > REC:SAGA Spec > suggestions/comments > List of Posts
Forum Topic - suggestions/comments: (1 Item)
View:  as 
 
 
suggestions/comments
I have read in detail some parts of the SAGA specification (pages 1-59 and 197-208). Below are my comments and 
suggesstions - they are not to be understood as strict "corrections".


Hope this helps,

Marjan.


-----------TYPOS

General: "A" and "an" are used incorrectly in many places.

Pg 4: Section is focusses -> Section focusses
	aspects on an OGF -> aspects of an OGF (not sure, but clearly something's wrong)

Pg 9: competetive -> competitive

Pg 10: Language, [3] -> Language [3],

Pg 12: section 3.5 -> Section 3.5
	from the saga::ns_directory class: -> add a closing )
	
Pg 13: otherwise it an -> otherwise an

Pg 14: interfaced -> interfaces
	implecitely -> implicitely
	
Pg 16: partial compliant -> partially compliant
	intents to provide -> intends
	
Pg 17: ommitted -> omitted

Pg 23: the allows state transitions -> allowed

Pg 34: successful Authorization -> authorization

Pg 35: and on backend -> and backend

Pg 38: associated with an exception -> with the exception

Pg 46: explicitely -> explicitly

Pg 47: inderictly -> indirectly

Pg 48: exception if involves -> if it involves

Pg 50: object however MAY -> object MAY
	untli -> until

Pg 197: intendet -> intended
	probablility -> probability
	copies -> copy

Pg 204: constructors apply and -> constructors and

Pg 205: valid replica location are -> locations are
	remove a replica locate from -> location from

Pg 208: sice of local replica -> size


-------ERRORS/INCONSISTENCIES

Pg 8: in item auxiliary API's for - API's for what?

Pg 22: all packages implementing -> all classes implementing

Pg 31:
- Constructor of saga::exception does not specify an OUT parameter for the newly created object, while constructors of 
other classes do. Likewise, the destructor of exception does not specify an IN parameter for the object to be destructed
.
- in constructor, Object should not be capitalized

Pg 32: The paragraph "The exceptions available..." states that this specification defines a normatove set of allowed 
exceptions for each method, while the next paragraph states that an implementation can also throw other exceptions.

Pg 33: compliant implementations in the instruction -> in Section 2.4

Pg 38: CONSTUCTOR of exception has no message parameter, although there is one in Specification (Page 31).

Pg 42: In specification, object.get_session's output is named session, while in details it is s.

Pg 43: Throws clause of clone() mentions NoSuccess, but Notes do not specify when NoSuccess can be thrown.

Pg 44:
-for "wait who gets done first", tc.wait() should have parameter "Any" because default is "All"
-what is the purpose of "buf=buf1;", seeing that buf is never read and is re-written in each loop pass?
-on each "create a new read task" inside the loop, the new task should also be put into tmap (if my understanding is 
correct, i.e. the read() method constructs a new task object each time)
-on "skip for stream type", NULL is passed as the output buffer, but the specification of saga::stream::read does not 
allow this

Pg 50: f.copy<saga::task::Task> -> <saga::task>

Pg 152: the acl parameter is missing in the list of inputs to set_acl()

Pg 202: ns_dir::find() is recursive by default, but logical_directory::find() is not - why?

Pg 203: constructor of logical_file:
-The parameter order is different than in the Specification on Page 199
-Inputs: url: location of directory -> of file

Pg 206: The update_location() method is missing a note about what happens if name_new is already in the list of replicas
.


-----------SUGGESTIONS/UNCLEAR POINTS

General: in many method specifications, the type and name of a parameter are the same, e.g. CONSTRUCTOR(in object object
, ...) - is this OK in SIDL?

Pg 17: "If the session argument is omitted, ... the default session." Will this not...
View Full Message

 
 


The Open Grid Forum Contact Webmaster | Report a problem | GridForge Help
This is a static archive of the previous Open Grid Forum GridForge content management system saved from host forge.ogf.org file /sf/discussion/do/listPosts/projects.ggf-editor/discussion.rec_saga_spec.topc3998 at Thu, 03 Nov 2022 23:19:25 GMT